Fix library class version error #1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychedelia
reviewed
May 31, 2025
There was a problem hiding this comment.
Might want to see if you can use something like https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Runtime.Version.html in order to avoid the need to keep this info string up to date.
|
Done - that's actually a pretty good idea. At first, I thought about |
Stefterv
approved these changes
Jun 17, 2025
|
Thanks @ThexXTURBOXx and @tychedelia 💙 |
|
@all-contributors please add @ThexXTURBOXx for code |
|
I've put up a pull request to add @ThexXTURBOXx! 🎉 |
|
@all-contributors please add @tychedelia for review |
|
I've put up a pull request to add @tychedelia! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I depended on a library compiled for Java 21 and stumbled upon this error.
I was quite puzzled by the error message - however after some testing I was able to confirm that Java 17 libraries work fine whilst Java 18 libraries (and later) do not.
This PR fixes the confusing error message.